Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In primeng calendar, date can be lined through or disabled using date… there is no way to disable years #12154

Merged
merged 1 commit into from
Aug 21, 2023
Merged

In primeng calendar, date can be lined through or disabled using date… there is no way to disable years #12154

merged 1 commit into from
Aug 21, 2023

Conversation

faisalahmedador
Copy link
Contributor

@faisalahmedador faisalahmedador commented Nov 9, 2022 •
edited
Loading

When maxDate or minDate is used, particular date or month gets disabled but there is no way to disable years outside the range of max or min date.

Related issue id: #12151, #12583

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

👋 Hi,
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 9, 2022
@ashikjs
Copy link
Contributor

ashikjs commented Jan 31, 2023

I also need this feature someone can approved this feature ??

@ashikjs
Copy link
Contributor

ashikjs commented Jan 31, 2023

@cetincakiroglu can you take a look this feature PR ?

@cetincakiroglu cetincakiroglu self-requested a review January 31, 2023 07:44
@cetincakiroglu cetincakiroglu added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Jan 31, 2023
@faisalahmedador faisalahmedador changed the title In primeng calendar, date can be lined through or disabled using date… there is no way to disable years In primeng calendar, date can be lined through or disabled using date… there is no way to disable years, #12583, #12151 Feb 28, 2023
@faisalahmedador faisalahmedador changed the title In primeng calendar, date can be lined through or disabled using date… there is no way to disable years, #12583, #12151 In primeng calendar, date can be lined through or disabled using date… there is no way to disable years, #12583 Feb 28, 2023
@faisalahmedador faisalahmedador changed the title In primeng calendar, date can be lined through or disabled using date… there is no way to disable years, #12583 In primeng calendar, date can be lined through or disabled using date… there is no way to disable years Feb 28, 2023
@mertsincan
Copy link
Member

Hi @faisal6699,

Sorry for the delayed response! Unfortunately, this PR is out of date. Could you please update it? I'll merge it asap.

Thanks a lot for your contribution!
Best Regards,

@mertsincan mertsincan added this to the 16.2.1 milestone Aug 18, 2023
@mertsincan mertsincan added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Aug 18, 2023
This was linked to issues Aug 18, 2023
In Calender year view disable year issue #12151
Closed
primeng calendar year view not work with *maxDate* and *minDate* not working #12583
Closed
This was referenced Aug 18, 2023
Closed
Closed
In primeng calendar, date can be lined through or disabled using date…
3cfdab6 
… template. But in year view there is no option to disable dates.

In my solution, if maxDate or minDate is there, then the years outside this range shoud be disabled.
@faisalahmedador faisalahmedador force-pushed the issue-12151-year-disable-feature branch from 82f5125 to 3cfdab6 Compare August 20, 2023 05:30
@vercel
Copy link

vercel bot commented Aug 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 5:38am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2023 5:38am

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test August 20, 2023 05:38 Inactive
@faisalahmedador
Copy link
Contributor Author

Hello @mertsincan,

Thanks for your response. I have resolved the conflict . You can now merge it if everything looks fine to you.

@mertsincan mertsincan merged commit 9ce344c into primefaces:master Aug 21, 2023
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Best Regards,

@mertsincan mertsincan removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Aug 26, 2023
@mertsincan mertsincan removed this from the 16.2.1 milestone Aug 26, 2023
@Niseel
Copy link

Niseel commented Nov 15, 2023

Hi @mertsincan Now how can I know from which version this error will no longer exist?
I'm using
Angular 14.2.2
PrimeNG ~14.1.0
and still see this error persisting.

@ashikjs
Copy link
Contributor

ashikjs commented Nov 15, 2023

@Niseel this issue resolved in 16.3.0 so you need to upgrade your PrimeNG to 16.3.0

@Niseel
Copy link

Niseel commented Nov 16, 2023

Angular 14.2.2
PrimeNG ~14.1.0
Hi @ashikjs Thanks for ur answer. Is there another way to fix this error without changing the version?

@ashikjs
Copy link
Contributor

ashikjs commented Nov 16, 2023

@Niseel Sorry i don't have idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cetincakiroglu cetincakiroglu Awaiting requested review from cetincakiroglu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@faisalahmedador @ashikjs @mertsincan @Niseel @cetincakiroglu